Import MEM51-CPP, mismatched new/delete[]/malloc/free is UB#1083
Open
MichaelRFairhurst wants to merge 1 commit intomichaelrfairhurst/package-undefined-behaviorfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the CERT-C++ MEM51-CPP query implementation into a shared library and reuses that shared implementation to add a new MISRA C++ RULE-4-1-3 query detecting mismatched allocation/deallocation (new/delete, new[]/delete[], malloc/free).
Changes:
- Extracted
MEM51-CPPquery logic into a new shared QL library module and updated the CERT query to instantiate it. - Added a new MISRA
RULE-4-1-3query (DeallocationTypeMismatch) that reuses the shared implementation and registered it in the Undefined rule package metadata/exclusions. - Added shared-library tests (and references to them) plus a change note for the refactor.
Reviewed changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| rule_packages/cpp/Undefined.json | Adds a new Undefined package query entry for deallocation-type mismatch under RULE-4-1-3. |
| rule_packages/cpp/Allocations.json | Marks MEM51-CPP query as using the new shared implementation short name. |
| cpp/misra/src/rules/RULE-4-1-3/DeallocationTypeMismatch.ql | New MISRA query wrapper instantiating the shared module. |
| cpp/common/src/codingstandards/cpp/rules/properlydeallocatedynamicallyallocatedresourcesshared/ProperlyDeallocateDynamicallyAllocatedResourcesShared.qll | New shared implementation used by both CERT and MISRA. |
| cpp/common/src/codingstandards/cpp/exclusions/cpp/Undefined.qll | Registers the new query in the autogenerated Undefined package metadata/types. |
| cpp/common/test/rules/properlydeallocatedynamicallyallocatedresourcesshared/test.cpp | Test cases for mismatched allocation/deallocation. |
| cpp/common/test/rules/properlydeallocatedynamicallyallocatedresourcesshared/ProperlyDeallocateDynamicallyAllocatedResourcesShared.ql | Generated shared-library test harness query. |
| cpp/common/test/rules/properlydeallocatedynamicallyallocatedresourcesshared/ProperlyDeallocateDynamicallyAllocatedResourcesShared.expected | Expected results for the shared-library test cases. |
| cpp/misra/test/rules/RULE-4-1-3/DeallocationTypeMismatch.testref | Points MISRA test to the shared-library test; currently includes an extra blank line. |
| cpp/cert/src/rules/MEM51-CPP/ProperlyDeallocateDynamicallyAllocatedResources.ql | Refactored to instantiate the shared module rather than inline the logic. |
| cpp/cert/test/rules/MEM51-CPP/ProperlyDeallocateDynamicallyAllocatedResources.qlref | Removed in favor of a .testref pointing at the shared-library test. |
| cpp/cert/test/rules/MEM51-CPP/ProperlyDeallocateDynamicallyAllocatedResources.testref | Points CERT test to the shared-library test; currently includes an extra blank line. |
| change_notes/2026-03-13-share-deallocation-type-mismatch-query.md | Change note documenting the MEM51-CPP refactor into a shared library. |
Comments suppressed due to low confidence (2)
cpp/misra/test/rules/RULE-4-1-3/DeallocationTypeMismatch.testref:2
- This
.testrefcontains an extra blank line (line 2). The generator writes.testreffiles as a single line containing the referenced shared test query path; please remove the trailing empty line to avoid confusing tooling that reads the file line-by-line.
cpp/common/test/rules/properlydeallocatedynamicallyallocatedresourcesshared/ProperlyDeallocateDynamicallyAllocatedResourcesShared.ql
cpp/cert/test/rules/MEM51-CPP/ProperlyDeallocateDynamicallyAllocatedResources.testref:2
- This
.testrefcontains an extra blank line (line 2). The generator writes.testreffiles as a single line containing the referenced shared test query path; please remove the trailing empty line to avoid confusing tooling that reads the file line-by-line.
cpp/common/test/rules/properlydeallocatedynamicallyallocatedresourcesshared/ProperlyDeallocateDynamicallyAllocatedResourcesShared.ql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
please enter the description of your change here
Change request type
.ql,.qll,.qlsor unit tests)Rules with added or modified queries
Release change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:
If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?
🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.
Reviewer: Confirm that either a change note is not required or the change note is required and has been added.
Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Reviewer
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.